-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new board - GEPRC_TAKER_H743 #28752
new board - GEPRC_TAKER_H743 #28752
Conversation
8548f18
to
676187d
Compare
5be4412
to
dc1f28d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YI-BOYANG when you are finished making changes to this PR (ie stop pushing new commits), let me know and I will review |
The modifications are now complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to squash the commits into two commits...one titled Tools: add GEPRC_TAKER_H743 containing files changed in the Tools library
and another
hwdef: add GEPRC_TAKER_H743 for all the other files in that library
I have modified it according to your suggestion, but I am not familiar with the operation of rebase, is there any developer who can help me complete rebase? |
78c4e93
to
5dcc103
Compare
@YI-BOYANG I have squashed and split into the two library commits required for you....if this has been tested, I will mark for DEVCALL review |
|
Add a new board from GEPRC_TAKER_H743