Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new board - GEPRC_TAKER_H743 #28752

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

YI-BOYANG
Copy link
Contributor

Add a new board from GEPRC_TAKER_H743
image

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Nov 27, 2024
@andyp1per andyp1per force-pushed the pr-taker-h743 branch 2 times, most recently from 5be4412 to dc1f28d Compare November 27, 2024 15:09
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hwurzburg
Copy link
Collaborator

@YI-BOYANG when you are finished making changes to this PR (ie stop pushing new commits), let me know and I will review

@YI-BOYANG
Copy link
Contributor Author

@YI-BOYANG when you are finished making changes to this PR (ie stop pushing new commits), let me know and I will review

The modifications are now complete.

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to squash the commits into two commits...one titled Tools: add GEPRC_TAKER_H743 containing files changed in the Tools library
and another
hwdef: add GEPRC_TAKER_H743 for all the other files in that library

libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/GEPRC_TAKER_H743/hwdef.dat Outdated Show resolved Hide resolved
@YI-BOYANG
Copy link
Contributor Author

You will also need to squash the commits into two commits...one titled Tools: add GEPRC_TAKER_H743 containing files changed in the Tools library and another hwdef: add GEPRC_TAKER_H743 for all the other files in that library

I have modified it according to your suggestion, but I am not familiar with the operation of rebase, is there any developer who can help me complete rebase?

@Hwurzburg
Copy link
Collaborator

@YI-BOYANG I have squashed and split into the two library commits required for you....if this has been tested, I will mark for DEVCALL review

@YI-BOYANG
Copy link
Contributor Author

@YI-BOYANG I have squashed and split into the two library commits required for you....if this has been tested, I will mark for DEVCALL review
The test has been completed before, this modification is not big, I think maybe the previous test results will not be affected.

@tridge tridge merged commit 1b51d6a into ArduPilot:master Dec 9, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants